Skip to content

Stop flag-solicitation matching RS256 and shell parameters - #21

Merged
arnelirobles merged 1 commit into
mainfrom
fix-flag-solicitation-price-regex
Nov 12, 2026
Merged

arnelirobles merged 1 commit into
mainfrom
fix-flag-solicitation-price-regex

Conversation

@arnelirobles

@arnelirobles arnelirobles commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Same change as BaryoDev/.github#35, which has the test table.

- untested: .github/workflows/flag-solicitation.yml
  why: copy of the .github workflow, tested by tests/flag-solicitation.sh in BaryoDev/.github

Summary by CodeRabbit

  • Bug Fixes
    • Improved detection of currency amounts in solicitation-related comments, including more precise matching for dollar, pound, peso, and currency-code formats.
    • Comments from repository owners, members, and collaborators are now skipped by the labeling and notification process.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

The solicitation workflow narrows currency matching and skips label-and-notify for comments by repository owners and users associated as OWNER, MEMBER, or COLLABORATOR.

Changes: Solicitation workflow

Layer / File(s) Summary
Scan and notification filters
.github/workflows/flag-solicitation.yml
The scan tightens matching for dollar, pound, peso, usd, eur, inr, and rs amounts. Existing number-suffix currency patterns and paid-work phrases remain. Label-and-notify now also skips commenters associated as OWNER, MEMBER, or COLLABORATOR.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

Merge Risk: Minimal · up to 14407

This change reduces false-positive solicitation flags, such as for RS256 and shell parameters, and skips flagging comments from owners, members, and collaborators. No actionable merge-blocking risk was identified.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@arnelirobles
arnelirobles marked this pull request as ready for review November 12, 2026 22:59
@arnelirobles
arnelirobles merged commit 8541831 into main Nov 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant